add importlib_metadata as dependency#227
Merged
Merged
Conversation
AnguseZhang
requested changes
Nov 22, 2021
AnguseZhang
left a comment
AnguseZhang
left a comment
Collaborator
There was a problem hiding this comment.
I think such requirement is too strict and may cause conflicts, since some of our python environments in offline package are Python3.8.
Member
Author
It means it takes effect only when Python version is less than 3.8. See https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#platform-specific-dependencies |
wanghan-iapcm
approved these changes
Nov 22, 2021
njzjz
added a commit
to njzjz/deepmd-kit
that referenced
this pull request
Nov 23, 2021
wanghan-iapcm
pushed a commit
to deepmodeling/deepmd-kit
that referenced
this pull request
Nov 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.